glm94/secure-core
1
0
Fork 0
Code Issues 9 Pull Requests Releases Wiki Activity

Crash On Missing Password Data #9

New Issue
Open
opened 2021-06-29 14:22:20 -05:00 by glm94 · 0 comments
glm94 commented 2021-06-29 14:22:20 -05:00
Owner
Copy Link
Copy Source

In the function "GetPasswordHashAndSalt" there's a crash bug if there's no password data associated with a user. The reader attempts to read before checking if there's even rows to read.

var reader = command.ExecuteReader();

//This read() needs to happen after the HasRows check..
reader.Read();

if (!reader.HasRows) return (string.Empty, string.Empty);
In the function "GetPasswordHashAndSalt" there's a crash bug if there's no password data associated with a user. The reader attempts to read before checking if there's even rows to read. ```C# var reader = command.ExecuteReader(); //This read() needs to happen after the HasRows check.. reader.Read(); if (!reader.HasRows) return (string.Empty, string.Empty); ```
glm94 added the bug label 2021-06-29 14:22:20 -05:00
Sign in to join this conversation.
main
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels bug
Milestone
No items
No Milestone
Assignees
Clear assignees
glm94 (Garritt McCune)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: glm94/secure-core#9